chore: moved android e2e to ubuntu #2196
Conversation
|
One thing I want to warn you in advance is that you will need to use Otherwise CI will fail due to insufficient memory heap (it may work in this PR, but after merging it may also start to fail randomly - at least that's what I had in my repository). And also I don't see enabling KVM action - without KVM emulator will not run as far as I remember (but maybe KVM is already enabled by default in newest GH runners 🤷♂️). |
|
@kirillzyusko thanks! I saw that you added such step (Free Disk Space (Ubuntu) from: https://github.com/marketplace/actions/free-disk-space-ubuntu). I am going to add it later on, just curious to see how the workflow behaves without it 😄 . Well I have to admit I did not know what is the purpose of enabling KVM step and wanted to try without it as well, but it looks like it's necessary indeed. |
|
@alduzy I see that workflow is constantly failing - you may want to try to change I think I was the person who changed it to |
|
Looks like the workflow is running stable after merging fixes from main branch. |
| - name: Enable KVM | ||
| run: | | ||
| echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules | ||
| sudo udevadm control --reload-rules | ||
| sudo udevadm trigger --name-match=kvm |
There was a problem hiding this comment.
It would be best to understand why kvm is needed here and what do we do here 😄
But if it works I guess we're just fine w/o it 🤷🏻♂️
There was a problem hiding this comment.
Testing the workflow without it right now 😄
There was a problem hiding this comment.
It is used by android-emulator-runner and it's necessary. I'm bringing it back
There was a problem hiding this comment.
What about the caches I asked in the main message?
There was a problem hiding this comment.
In my case AVD cache helped to shave off 1-2 minutes when I boot the emulator. Curious to see the result in your project 👀
## Description This PR intents to move android e2e test to ubuntu to avoid random crashes. Inspired by changes made by @kirillzyusko in [react-native-keyboard-controller](https://github.com/kirillzyusko/react-native-keyboard-controller). ## Changes - Changed workflow's `runs-on` - Bump deps - Added necessary extra steps <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [x] Ensured that CI passes
Description
This PR intents to move android e2e test to ubuntu to avoid random crashes. Inspired by changes made by @kirillzyusko in react-native-keyboard-controller.
Changes
runs-onTest code and steps to reproduce
Checklist